[Skiboot] [PATCH] flash: Make PNOR partition encoding size 64 bit safe.

Reza Arbab arbab at linux.ibm.com
Thu May 5 05:00:55 AEST 2022


On Wed, May 04, 2022 at 09:16:40AM +0530, Aneesh Kumar K V wrote:
>On 5/4/22 12:52 AM, Reza Arbab wrote:
>>Shouldn't we revise these properties instead of removing them? I'm 
>>thinking that regardless of what Linux assumes, the device tree is 
>>expected to provide values for them.
>
>considering linux is not using #address-cells it becomes the standard 
>now. ie, we want reg to be a 64 bit encoding, rather than one based on 
>#address-cells and #size-cells. Any new user should follow that. Hence 
>the removal of those property cells.

Okay, looking at an actual device tree, it makes sense now. In fact, dtc 
even warns about those properties:

   # dtc -I fs -O dts /sys/firmware/devicetree/base
   ...
   <stdout>: Warning (avoid_unnecessary_addr_size): /ibm,opal/flash at 0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
  

Committed to master.  

-- 
Reza Arbab


More information about the Skiboot mailing list