[Skiboot] [PATCH] ci: Remove Centos 8

[Dan Horák]

On Mon, 7 Mar 2022 09:31:56 +0000
Joel Stanley <joel at jms.id.au> wrote:

> On Mon, 7 Mar 2022 at 09:23, Dan Horák <dan at danny.cz> wrote:
> >
> > On Mon,  7 Mar 2022 12:54:21 +1030
> > Joel Stanley <joel at jms.id.au> wrote:
> >
> > > With Centos 8 gone "EOL", the Centos 8 repositories have been moved(!)
> > > causing the build to fail:
> > >
> > >  Step 2/14 : RUN yum -y update && yum clean all
> > >   ---> Running in 49e78cad4cda
> > >  CentOS Linux 8 - AppStream                      424  B/s |  38  B     00:00
> > >  Error: Failed to download metadata for repo 'appstream': Cannot prepare
> > >  internal mirrorlist: No URLs in mirrorlist
> > >
> > > Remove the build from CI as it no longer works.
> >
> > how about switching to CentOS Stream 8 or to Rocky or Alma? Do we want
> > running the CI on RHEL-8 (or equivalent)?
> 
> Running on RHEL would make sense, as that's what internally IBM builds
> on. I'm not aware of a way to do that using Github actions though?

seems only Ubuntu is now available in Github actions, I haven't thought
fully about this aspect. Thus

LGTM

Reviewed-by: Dan Horák <dan at danny.cz>


> The builds have been failing for some time, and I was quite surprised
> that a distro would break existing images, hence the removal.

I think this was intentional to explicitly notify the users about the
EOL state of CentOS 8.
 
> >
> > Might be worth to also remove Fedora 33, because it has been EOL for a
> > while now.
> 
> Sure. I'd ack that patch.


		Dan
 
> >
> >
> >                 Dan
> >
> >
> > > Signed-off-by: Joel Stanley <joel at jms.id.au>
> > > ---
> > >  .github/workflows/docker-builds-checks.yml |  2 +-
> > >  opal-ci/Dockerfile-centos8                 | 16 -------------
> > >  opal-ci/build-centos8.sh                   | 28 ----------------------
> > >  3 files changed, 1 insertion(+), 45 deletions(-)
> > >  delete mode 100644 opal-ci/Dockerfile-centos8
> > >  delete mode 100755 opal-ci/build-centos8.sh
> > >
> > > diff --git a/.github/workflows/docker-builds-checks.yml b/.github/workflows/docker-builds-checks.yml
> > > index bd9733628209..2e665b1fe95e 100644
> > > --- a/.github/workflows/docker-builds-checks.yml
> > > +++ b/.github/workflows/docker-builds-checks.yml
> > > @@ -12,7 +12,7 @@ jobs:
> > >        fail-fast: false
> > >
> > >        matrix:
> > > -        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-rolling, centos7, centos8, fedora33, fedora34, fedora35, docs ]
> > > +        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-rolling, centos7, fedora33, fedora34, fedora35, docs ]
> > >
> > >      steps:
> > >        - uses: actions/checkout at v2
> > > diff --git a/opal-ci/Dockerfile-centos8 b/opal-ci/Dockerfile-centos8
> > > deleted file mode 100644
> > > index d7cec7471389..000000000000
> > > --- a/opal-ci/Dockerfile-centos8
> > > +++ /dev/null
> > > @@ -1,16 +0,0 @@
> > > -FROM centos:8
> > > -RUN yum -y update && yum clean all
> > > -RUN yum -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel openssl-devel openssl
> > > -
> > > -RUN mkdir /opt/cross
> > > -RUN if [ `arch` = "x86_64" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.4.0/x86_64-gcc-8.4.0-nolibc-powerpc64-linux.tar.gz; tar -C /opt/cross -xf x86_64-gcc-8.4.0-nolibc-powerpc64-linux.tar.gz; fi
> > > -RUN if [ `arch` = "ppc64le" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/ppc64le/8.4.0/ppc64le-gcc-8.4.0-nolibc-powerpc64-linux.tar.gz; tar -C /opt/cross -xf ppc64le-gcc-8.4.0-nolibc-powerpc64-linux.tar.gz; fi
> > > -
> > > -RUN yum install -y flex bison
> > > -RUN curl -L https://github.com/dgibson/dtc/archive/refs/tags/v1.6.1.tar.gz|tar xfz -
> > > -RUN (cd dtc-1.6.1; make PREFIX=/usr/local install)
> > > -RUN if [ `arch` = "x86_64" ]; then curl -L -O http://public.dhe.ibm.com/software/server/powerfuncsim/p8/packages/v1.0-2/systemsim-p8-1.0-2.el7.x86_64.rpm; yum install -y systemsim-p8-1.0-2.el7.x86_64.rpm; fi
> > > -RUN if [ `arch` = "x86_64" ]; then dnf -y install http://public.dhe.ibm.com/software/server/powerfuncsim/p9/packages/v1.1-0/systemsim-p9-1.1-0.f22.x86_64.rpm; fi
> > > -RUN if [ `arch` = "x86_64" ]; then dnf -y install http://public.dhe.ibm.com/software/server/powerfuncsim/p10/packages/v1.2-1/rhel8/systemsim-p10-1.2-1.x86_64.rpm; fi
> > > -COPY . /build/
> > > -WORKDIR /build
> > > diff --git a/opal-ci/build-centos8.sh b/opal-ci/build-centos8.sh
> > > deleted file mode 100755
> > > index b589e7468291..000000000000
> > > --- a/opal-ci/build-centos8.sh
> > > +++ /dev/null
> > > @@ -1,28 +0,0 @@
> > > -#!/bin/bash
> > > -
> > > -set -uo pipefail
> > > -set -e
> > > -set -vx
> > > -
> > > -if [ $(arch) == "x86_64" ]; then
> > > -    export CROSS=/opt/cross/gcc-8.4.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
> > > -fi
> > > -if [ $(arch) == "ppc64le" ]; then
> > > -    export CROSS=/opt/cross/gcc-8.4.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
> > > -fi
> > > -
> > > -MAKE_J=$(nproc)
> > > -
> > > -make -j${MAKE_J} all
> > > -make -j${MAKE_J} check
> > > -(make clean; cd external/gard && CROSS= make -j${MAKE_J})
> > > -(cd external/pflash; make -j${MAKE_J})
> > > -make clean
> > > -SKIBOOT_GCOV=1 make -j${MAKE_J}
> > > -SKIBOOT_GCOV=1 make -j${MAKE_J} check
> > > -
> > > -make clean
> > > -rm -rf builddir
> > > -mkdir builddir
> > > -make SRC=$(pwd) -f ../Makefile -C builddir -j${MAKE_J}
> > > -make clean
> > > --
> > > 2.34.1
> > >
> > > _______________________________________________
> > > Skiboot mailing list
> > > Skiboot at lists.ozlabs.org
> > > https://lists.ozlabs.org/listinfo/skiboot
> > _______________________________________________
> > Skiboot mailing list
> > Skiboot at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/skiboot