[Skiboot] [PATCH 02/16] [PATCH 02/16] opencapi5: update npu3

Frederic Barrat fbarrat at linux.ibm.com
Wed Sep 8 22:17:30 AEST 2021



On 20/08/2021 11:45, Christophe Lombard wrote:
> Create npu3 entry in the device tree only for P9P chip to avoid confusion
> with the following chips. NPU3 is only available for Axone.
> 
> Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> ---

Looks ok. Will likely disappear if the series to remove npu3 support is 
merged first.
Reviewed-by: Frederic Barrat <fbarrat at linux.ibm.com>



>   hw/npu3.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/npu3.c b/hw/npu3.c
> index 03461373..0a9bbce8 100644
> --- a/hw/npu3.c
> +++ b/hw/npu3.c
> @@ -113,9 +113,7 @@ static bool npu3_dt_create(void)
>   	struct dt_node *xscom;
> 
>   	/* npu3 chips only */
> -	if (proc_gen < proc_gen_p9 ||
> -	    chip->type == PROC_CHIP_P9_NIMBUS ||
> -	    chip->type == PROC_CHIP_P9_CUMULUS)
> +	if (chip->type != PROC_CHIP_P9P)
>   		return false;
> 
>   	dt_for_each_compatible(dt_root, xscom, "ibm,xscom")
> 


More information about the Skiboot mailing list