[Skiboot] [PATCH] uart: Give SIMICS some more time

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sat May 29 00:42:52 AEST 2021


On 5/27/21 3:36 PM, Cédric Le Goater wrote:
> Increase timeout introduced in commit 6bf21350da32 ("uart: Drop
> console write data if BMC becomes unresponsive") when running under
> SIMICS.
> 
> Signed-off-by: Cédric Le Goater <clg at kaod.org>

Thanks! Merged to master as 3ed6afd7.

-Vasant


> ---
>   hw/lpc-uart.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/hw/lpc-uart.c b/hw/lpc-uart.c
> index a584eba9109d..834011b371f7 100644
> --- a/hw/lpc-uart.c
> +++ b/hw/lpc-uart.c
> @@ -128,6 +128,9 @@ static bool uart_timed_out(unsigned long msecs)
>   	if (uart_check_tx_room())
>   		return false;
>   
> +	if (chip_quirk(QUIRK_SLOW_SIM))
> +		msecs *= 5;
> +
>   	if (tb_compare(mftb(), uart_tx_full_time + msecs_to_tb(msecs)) == TB_AAFTERB)
>   		return true;
>   
> 



More information about the Skiboot mailing list