[Skiboot] [PATCH] secvar/secvar_util: Properly free memory on zalloc fail

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu May 13 23:51:45 AEST 2021

On 4/22/21 1:35 AM, Nick Child wrote:
> If allocating the secure variable name of a secure variable struct,
> `secvar->key`, fails then the secvar struct should be freed before
> returning NULL. Previously, if this allocation fails, then only the
> `secvar->key` is freed (which is likely a typo) leaving the allocated
> `secvar` struct allocated and returning NULL. This memory leak can be
> seen with the static analysis tool `cppcheck`. After running valgrind
> tests, this commit ensures that memory is properly freed if an error
> occurs when allocating the `key` field of the `secvar` struct.
> Signed-off-by: Nick Child <nick.child at ibm.com>

Thanks! Merged to master as e964b78d5.


More information about the Skiboot mailing list