[Skiboot] [PATCH] secvar/backend: use endian-aware types in edk2.h

Daniel Axtens dja at axtens.net
Wed Jun 23 19:37:30 AEST 2021


> I'll try again, AFAIK you can use le16 for it and do `s16 tz = 
> le16_to_cpu(efi->timezone)` and the signedness works out.
>
> Yes you do lose the signedness of the type when you do that but it seems 
> to be the done thing. For non trivial cases you might have a host native
> structure as well and convert between them.
>

OK, I'm sold. I'll respin it with timezone just being le16. I think the
comment above the data structure makes its signedness sufficiently clear.

Kind regards,
Daniel


More information about the Skiboot mailing list