[Skiboot] [PATCH v2 3/5] secvar/backend: fix comment of get_hash_to_verify

Daniel Axtens dja at axtens.net
Mon Jun 21 18:26:39 AEST 2021


get_hash_to_verify claims to return a negative error code in the
case of error. It actually returns NULL. Fix the comment.

Signed-off-by: Daniel Axtens <dja at axtens.net>
---
 libstb/secvar/backend/edk2-compat-process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstb/secvar/backend/edk2-compat-process.c b/libstb/secvar/backend/edk2-compat-process.c
index b39f35e0c3dc..3ef3cf73c8f7 100644
--- a/libstb/secvar/backend/edk2-compat-process.c
+++ b/libstb/secvar/backend/edk2-compat-process.c
@@ -572,7 +572,7 @@ static int verify_signature(const struct efi_variable_authentication_2 *auth,
  * Create the hash of the buffer
  * name || vendor guid || attributes || timestamp || newcontent
  * which is submitted as signed by the user.
- * Returns the sha256 hash, else negative error code.
+ * Returns the sha256 hash, else NULL.
  */
 static char *get_hash_to_verify(const char *key, const char *new_data,
 				const size_t new_data_size,
-- 
2.30.2



More information about the Skiboot mailing list