[Skiboot] [PATCH 58/61] P10 Cleanup special wakeup and xive stop api usage

[Cédric Le Goater]

>> diff --git a/hw/xive2.c b/hw/xive2.c
>> index b79635cc9..f559b0f9a 100644
>> --- a/hw/xive2.c
>> +++ b/hw/xive2.c
>> @@ -3022,34 +3022,10 @@ static void xive_configure_ex_special_bar(struct xive *x, struct cpu_thread *c)
>>  
>>  void xive2_late_init(void)
>>  {
>> -	struct cpu_thread *c;
>> -
>>  	prlog(PR_INFO, "SLW: Configuring self-restore for NCU_SPEC_BAR\n");
>> -	for_each_present_cpu(c) {
>> -		if(cpu_is_thread0(c)) {
>> -			struct proc_chip *chip = get_chip(c->chip_id);
>> -			struct xive *x = chip->xive;
>> -			uint64_t xa, val, rc;
>> -			xa = XSCOM_ADDR_P10_NCU(pir_to_core_id(c->pir), P10_NCU_SPEC_BAR);
>> -			val = (uint64_t)x->tm_base | P10_NCU_SPEC_BAR_ENABLE;
>> -			/* Bail out if wakeup engine has already failed */
>> -			if ( wakeup_engine_state != WAKEUP_ENGINE_PRESENT) {
>> -				prlog(PR_ERR, "XIVE p9_stop_api fail detected\n");
>> -				break;
>> -			}
>>  			/*
>> -			 * TODO (p10): need P10 stop state engine
>> +			 * TODO (p10): need P10 stop state engine and fix for STOP11
>>  			 */
>> -			rc = p9_stop_save_scom((void *)chip->homer_base, xa, val,
>> -				P9_STOP_SCOM_REPLACE, P9_STOP_SECTION_EQ_SCOM);
>> -			if (rc) {
>> -				xive_cpu_err(c, "p9_stop_api failed for NCU_SPEC_BAR rc=%lld\n",
>> -				rc);
>> -				wakeup_engine_state = WAKEUP_ENGINE_FAILED;
>> -			}
>> -		}
>> -	}
> 
> This should probably be merged with the xive2 code that added it.

yes. I agree.

C.