[Skiboot] [PATCH] libstb/secvar: export functions used by secvarctl

[Vasant Hegde]

On 5/12/21 9:52 PM, Nick Child wrote:
> Hey Daniel,
> 
> Thanks again for helping with this secvarctl-to-skiboot work.
> I would imagine some of the syntax we used in secvarctl is not
> consistent enough with SkiBoot. For example, I recommend
> changing the added error message in `get_esl_signature_list` to:
> 
> -       if (buflen < sizeof(EFI_SIGNATURE_LIST) || !buf)
> +       if (buflen < sizeof(EFI_SIGNATURE_LIST) || !buf) {
> +               prlog(PR_ERR, "ESL does not have enough data to be valid\n");
>                  return NULL;
> +       }

Yes. Please update the error message.

> 
> I am also wondering what the maintainers will think of the doxygen-esc
> function documentation that gets added to edk-compat-process.h.

This is probably ok.

-Vasant