[Skiboot] [PATCH v2 2/6] core/cpu: remove POWER8 IPI loop

Nicholas Piggin npiggin at gmail.com
Fri Dec 17 13:17:20 AEDT 2021


POWER8 does not have to loop sending IPIs until the destination wakes
up. cpu_wake() only sends IPI so that should be enough here too.

This will help the next patch make a common IPI sending function.

Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 core/cpu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/core/cpu.c b/core/cpu.c
index 1371cd34e..20b3f6af3 100644
--- a/core/cpu.c
+++ b/core/cpu.c
@@ -609,10 +609,8 @@ static void reconfigure_idle_start(void)
 
 	if (proc_gen == proc_gen_p8) {
 		for_each_available_cpu(cpu) {
-			while (cpu->in_sleep || cpu->in_idle) {
+			if (cpu->in_sleep || cpu->in_idle)
 				icp_kick_cpu(cpu);
-				cpu_relax();
-			}
 		}
 	} else if (proc_gen == proc_gen_p9 || proc_gen == proc_gen_p10) {
 		for_each_available_cpu(cpu) {
-- 
2.23.0



More information about the Skiboot mailing list