[Skiboot] [PATCH 1/2] POWER9 Cleanups: de-assert SPW

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Aug 3 00:33:53 AEST 2021


From: "Pratik R. Sampat" <psampat at linux.ibm.com>

De-assert special wakeup bits for the case when SPWU bit is set, however
the core is gated to maintain a coherent state for special wakeup.

Signed-off-by: Pratik R. Sampat <psampat at linux.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 core/direct-controls.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/core/direct-controls.c b/core/direct-controls.c
index 65cf122c1..0274367da 100644
--- a/core/direct-controls.c
+++ b/core/direct-controls.c
@@ -302,6 +302,8 @@ static int p9_core_set_special_wakeup(struct cpu_thread *cpu)
 			 * raise error.
 			 */
 			if (dctl_core_is_gated(cpu)) {
+				/* Deassert spwu for this strange error */
+				xscom_write(chip_id, swake_addr, 0);
 				prlog(PR_ERR, "Failed special wakeup on %u:%u"
 						" as CORE_GATED is set\n",
 						chip_id, core_id);
-- 
2.31.1



More information about the Skiboot mailing list