[Skiboot] [PATCH 1/1] secvar/backend/edk2.h: mark structs as __packed explicitly

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Apr 1 02:19:45 AEDT 2021


On 3/23/21 3:28 AM, Daniel Axtens wrote:
> The structes we import from EDK2 are expected to be packed.
> The code we imported does this a #pragma pack, but it doesn't
> restore the original non-packed state at the end of the header.
> 
> Rather than changing that, just explictly pack every structure.
> 
> The resulting skiboot.elf has the same disassembly (objdump -dr)
> and readelf -a output, but I haven't been able to test this on
> a real machine.

Thanks! Merged to master as bc54b94fe.

-Vasant


More information about the Skiboot mailing list