[Skiboot] [PATCH v3] platform/mowgli: Add mowgli.c

Oliver O'Halloran oohall at gmail.com
Tue Sep 29 14:46:18 AEST 2020


On Mon, Sep 28, 2020 at 5:45 PM Dan Horák <dan at danny.cz> wrote:
>
> On Fri, 25 Sep 2020 11:19:10 +0800
> Lulu Su <Lulu_Su at wistron.com> wrote:
>
> > From: LuluTHSu <Lulu_Su at wistron.com>
> >
> > This is the initial version.
> >
> > Cc: skiboot-stable at lists.ozlabs.org
> > Cc: skiboot-stable at lists.ozlabs.org # skiboot-op940.x
> > Signed-off-by: LuluTHSu <Lulu_Su at wistron.com>
>
> LGTM, although I can't comment on the internals, but they look sane
>
> 2 nitpicks
> - for the mowgli_phb_table - redundant empty line
> - mixing tabs and spaces in the platform declaration, but this affects
> most of the platform, I'll send a cleanup patch

Don't worry about it. I'll fix it up when merging.


More information about the Skiboot mailing list