[Skiboot] [PATCH 1/4] hw/lpc: add helpers to copy in/out of fw space

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Oct 30 03:17:46 AEDT 2020

On 10/27/20 5:46 AM, Oliver O'Halloran wrote:
> The normal LPC APIs are limited to 1/2/4 byte accesses. The existing SFC
> controller, mbox and HIOMAP flash drivers implement more or less the
> same copy loops to move data into and out of the LPC firmware space.
> Add a single generic helper that can replace the seperate
> implementations.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Looks good to me.

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


More information about the Skiboot mailing list