[Skiboot] [PATCH 2/4] phb4: Add debugfs entries for internal tables

[Cédric Le Goater]

On 11/24/20 10:58 AM, Frederic Barrat wrote:
> 
> 
> On 05/11/2020 17:15, Cédric Le Goater wrote:
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
>> ---
>>   hw/phb4.c | 118 +++++++++++++++++++++++++-----------------------------
>>   1 file changed, 55 insertions(+), 63 deletions(-)
>>
>> diff --git a/hw/phb4.c b/hw/phb4.c
>> index f5bef9643c04..8353abcad2f7 100644
>> --- a/hw/phb4.c
>> +++ b/hw/phb4.c
> 
>> @@ -5895,6 +5880,13 @@ static void phb4_create(struct dt_node *np)
>>         dt_add_property_string(np, "status", "okay");
>>   +    /* Add debug nodes for real PHBs */
>> +    if (p->phb.phb_type != phb_type_npu_v2 &&
>> +        p->phb.phb_type != phb_type_npu_v2_opencapi &&
>> +        p->phb.phb_type != phb_type_npu_v3)
>> +        for (i = 0; i < ARRAY_SIZE(phb4_ioda_tables); i++)
>> +            opal_debug_create(phb4_ioda_tables[i].name,
>> +                      np, p, &phb4_ioda_ops);
>>       return;
> 
> 
> All those if statements are useless. If we are here, we're creating a phb_type_pcie_v4 PHB, it's explicit a few lines above in that function.
> Virtual PHBs are created somewhere else.

OK. I had some crash when dumping the tables. That fixed it but
I will recheck. 

Thanks,

C. 


> 
>   Fred
>