[Skiboot] [PATCH v4 01/18] libstb/secureboot: use platform.terminate instead of hard abort

Oliver O'Halloran oohall at gmail.com
Tue May 12 13:49:06 AEST 2020

On Mon, 2020-05-11 at 16:31 -0500, Eric Richter wrote:
> Halting the boot via an abort() call will cause the BMC to keep
> restarting the machine indefinitely.

The BMC is supposed to detect the host bootlooping and stop powering it
on after 5 or so.

> Ending via platform.terminate()
> should be cleaner and prevent needless bootloops.

abort() is a #defined as assert(0) which results in a call to

void __noreturn assert_fail(const char *msg, const char *file,
                                unsigned int line, const char *function)
        static bool in_abort = false;

        if (in_abort)
                for (;;) ;
        in_abort = true;

        /* snip comment */
        prlog(PR_EMERG, "assert failed at %s:%u: %s\n", file, line, msg);

        /* Save crashing CPU details */

        if (platform.terminate)

        for (;;) ;

So I'm not really seeing how this is an improvement. The terminate
callback is usually ipmi_terminate() which will also trigger an MPIPL
on the systems which support it. That might be the cause of your boot

Vasant, do you have anything to add?

More information about the Skiboot mailing list