[Skiboot] [RFC PATCH v5 01/16] doc/opal-uv-abi.rst

Thiago Jung Bauermann bauerman at linux.ibm.com
Thu Mar 26 12:48:23 AEDT 2020


Hello Ryan,

Ryan Grimm <grimm at linux.ibm.com> writes:

> +Syntax
> +~~~~~~
> +
> +.. code-block:: c
> +
> +        long ucall(unsigned long UV_READ_SCOM,
> +                unsigned long *retbuf,
> +                u64 partid,
> +                u64 pcb_addr)

Just one nit here: perhaps remove the "unsigned long" from the
UV_READ_SCOM constant? Despite it being in upper case, the type
information makes it look like it's a variable.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center


More information about the Skiboot mailing list