[Skiboot] [RFC PATCH v5 12/16] Load the ultravisor from flash and decompress

[Alexey Kardashevskiy]

On 25/03/2020 12:45, Oliver O'Halloran wrote:
> On Wed, Mar 25, 2020 at 11:51 AM Alexey Kardashevskiy <aik at ozlabs.ru> wrote:
>>
>>
>>
>> On 25/03/2020 02:22, Ryan Grimm wrote:
>>> On Thu, 2020-03-12 at 12:08 +1100, Alexey Kardashevskiy wrote:
>>>>
>>>>> diff --git a/core/init.c b/core/init.c
>>>>> index f124f893..1300ab03 100644
>>>>> --- a/core/init.c
>>>>> +++ b/core/init.c
>>>>> @@ -1300,6 +1300,7 @@ void __noreturn __nomcount
>>>>> main_cpu_entry(const void *fdt)
>>>>>
>>>>>     preload_capp_ucode();
>>>>>     start_preload_kernel();
>>>>> +   uv_preload_image();
>>>>
>>>>
>>>> Can this be a part of init_uv()?
>>>>
>>>
>>> It could but isn't the point to preload it separately early in the boot
>>> cause loading from flash or FSP is slow?
>>
>>
>> No idea about how slow it is (Oliver may want to comment) but how moving
>> it earlier makes it faster? It is not running in parallel with something
>> else here. Thanks,
> 
> Didn't look at the code, but the preload_* functions create a job
> thread which handles the load in the background while the main thread
> is doing other things.


aaah right, the code calls start_preload_resource() +
wait_for_resource_loaded(), makes sense now. Thanks,



-- 
Alexey