[Skiboot] [PATCH] platform/mihawk: support dynamic PCIe slot table

Oliver O'Halloran oohall at gmail.com
Wed Mar 25 09:28:13 AEDT 2020

On Thu, Mar 12, 2020 at 8:05 PM Joy Chu/WHQ/Wistron <Joy_Chu at wistron.com> wrote:
> Hi Oliver,
> As in your previous comment:
> ""Can you use ipmi_queue_msg_sync() instead of the callback and open-coded delay loop? The only problem I can see is that if the BMC doesn't respond we'd hit the timeout in the current code while
> ipmi_queue_msg_sync() will wait forever. We could always add a timeout to the _sync version though.""
> I still have no idea about how to add the timeout when using ipmi_queue_msg_sync().
> Would you please give us some hints?

Hi Joy,

Sorry about the delay. I thought I sent a reply the other day, but it
looks like it didn't actually send.

Anyway, currently there is no code to implement a synchronous message
with a timeout. What I was thinking was that rather than having the
platform code implement one by hand we should provide it as a part of
the core API. That said, I'm a bit iffy about the concept. If we have
a message that times out what should we be doing with the message on
the skiboot side? If the BMC doesn't respond we can't just leave the
message sitting on the IPMI queue. What is happening on the BMC side
that prevents it sending a timely response?


More information about the Skiboot mailing list