[Skiboot] [PATCH trivial] make_version: Use --tags option

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Mar 23 18:34:50 AEDT 2020


On 3/23/20 12:37 PM, Oliver O'Halloran wrote:
> On Fri, Mar 13, 2020 at 4:56 PM Vasant Hegde
> <hegdevasant at linux.vnet.ibm.com> wrote:
>>
>> On 3/12/20 10:55 PM, Stewart Smith wrote:
>>> On Thu, Mar 12, 2020, at 5:11 AM, Vasant Hegde wrote:
>>>> By default (without --all or --tags) git describe only shows annotated
>>>> tags. Lets add --tags option so that we generate version based on latest
>>>> released version.
>>>
>>> This would mean that not signed tags could be used, which is probably not ideal?
>>
>> Stewart,
>>
>> Sorry. I should have expanded the description.
>>
>> I'd prefer signed tags. But our v6.5 is not signed. So when we build skiboot its
>> generating
> 
> I think I re-pushed it as a signed tag at some point. Try delete it
> with git tag -d v6.5 and fetch it again.

This worked for me. Thanks!

We can ignore this patch.

-Vasant



More information about the Skiboot mailing list