[Skiboot] [PATCH 2/2] errorlog: Increase the severity of abnormal reboot events
Klaus Heinrich Kiwi
klaus at linux.vnet.ibm.com
Tue Mar 10 06:49:18 AEDT 2020
On 3/9/2020 12:35 PM, Vasant Hegde wrote:
> On 3/5/20 7:03 PM, Klaus Heinrich Kiwi wrote:
>> I think this is OK since OPAL_RC_ABNORMAL_REBOOT always a result of a
>> OPAL_CEC_REBOOT2 OPAL call which itself causes a OPAL TI checkstop.
>> The fact that we respond to a "Reboot requested" with a
>> checkstop/PANIC is pre-existing to this patch, so it feels like
>> setting the record straight.
>> Reviewed-by: Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>
>> I'm a bit curious, though, why we do this, because it looks like the
>> platform is asking us to reboot, not to checkstop..
> We call checkstop so that OCC can collect debug data before rebooting.
Thanks! By the way, I should have rtfm here
Reviewed-by: Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>
More information about the Skiboot