[Skiboot] [PATCH] tpm_i2c_nuvoton: check TPM vendor id register during probe
Klaus Heinrich Kiwi
klaus at linux.vnet.ibm.com
Fri Mar 6 22:30:53 AEDT 2020
On 3/5/2020 11:40 PM, Oliver O'Halloran wrote:
>>> + free(tpm_device);
>>> + continue;
> One more thing: Should we be doing goto disable; here rather than
> continue? The kernel will try to use the TPM later on since it's still
> in the DT.
This also caught my attention, as everywhere else we are jumping to
outside the loop and aborting..
but in this case, and if there are multiple "compatible=nuvoton,npct650"
nodes, wouldn't we abort mid-probe when we encounter the first
considered invalid? is that really what we want?
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>
More information about the Skiboot