[Skiboot] [PATCH 2/2] errorlog: Increase the severity of abnormal reboot events

[Klaus Heinrich Kiwi]

On 3/4/2020 5:58 AM, Vasant Hegde wrote:
> CC: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>   core/platform.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/core/platform.c b/core/platform.c
> index 9593f3af2..85b2cd24f 100644
> --- a/core/platform.c
> +++ b/core/platform.c
> @@ -27,7 +27,7 @@ bool manufacturing_mode = false;
>   struct platform	platform;
> 
>   DEFINE_LOG_ENTRY(OPAL_RC_ABNORMAL_REBOOT, OPAL_PLATFORM_ERR_EVT, OPAL_CEC,
> -		 OPAL_CEC_HARDWARE, OPAL_PREDICTIVE_ERR_FAULT_RECTIFY_REBOOT,
> +		 OPAL_CEC_HARDWARE, OPAL_ERROR_PANIC,
>   		 OPAL_ABNORMAL_POWER_OFF);
> 
>   /*
> 

I think this is OK since OPAL_RC_ABNORMAL_REBOOT always a result of a 
OPAL_CEC_REBOOT2 OPAL call which itself causes a OPAL TI checkstop.

The fact that we respond to a "Reboot requested" with a checkstop/PANIC 
is pre-existing to this patch, so it feels like setting the record straight.

Reviewed-by: Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>

I'm a bit curious, though, why we do this, because it looks like the 
platform is asking us to reboot, not to checkstop..

Thanks,

  -Klaus


-- 
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>