[Skiboot] [PATCH] hw/fsp: Remove stray va_end() in __fsp_fillmsg()

Oliver O'Halloran oohall at gmail.com
Thu Mar 5 16:12:38 AEDT 2020


__fsp_fillmsg() is called from fsp_fillmsg() and fsp_mkmsg(). Both
callers wrap it in a va_start() / va_end() pair so using va_end()
inside the function is almost certainly wrong.

Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
circa 2012 ben code, might be the oldest bug in skiboot.
---
---
 hw/fsp/fsp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
index 196fa34d5dbf..392cf5d36409 100644
--- a/hw/fsp/fsp.c
+++ b/hw/fsp/fsp.c
@@ -995,7 +995,6 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod,
 
 	for (i = 0; i < add_words; i++)
 		fsp_msg_set_data_word(msg, i, va_arg(list, unsigned int));
-	va_end(list);
 }
 
 void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u32 add_words, ...)
-- 
2.21.1



More information about the Skiboot mailing list