[Skiboot] [PATCH 07/11] xive/p9: Use sizeof() instead of hardcoded values

[Gustavo Romero]

On 6/4/20 10:21 AM, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>   hw/xive.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xive.c b/hw/xive.c
> index 3fce079d2721..a3a8eb05776b 100644
> --- a/hw/xive.c
> +++ b/hw/xive.c
> @@ -174,9 +174,10 @@
>    *
>    * TODO: adjust the VC BAR range for END ESBs on this value
>    */
> +#define EQ_PER_PAGE		(0x10000 / sizeof(struct xive_eq))
> +
>   #define XIVE_EQ_ORDER		20 /* 1M ENDs */
>   #define XIVE_EQ_COUNT		(1ul << XIVE_EQ_ORDER)
> -#define EQ_PER_PAGE		(0x10000 / 32) // Use sizeof ?
>   #define IND_EQ_TABLE_SIZE	((XIVE_EQ_COUNT / EQ_PER_PAGE) * 8)
>   
>   #define XIVE_EQ_SHIFT		(16 + 1) /* ESn + ESe pages */
> @@ -208,12 +209,12 @@
>    *
>    * XXX Adjust that based on BAR value ?
>    */
> +#define VP_PER_PAGE		(0x10000 / sizeof(struct xive_vp))
>   
>   #define NVT_SHIFT		19	/* in sync with EQ_W6_NVT_INDEX */
>   
>   #define MAX_VP_ORDER		NVT_SHIFT /* 512k */
>   #define MAX_VP_COUNT		(1ul << MAX_VP_ORDER)
> -#define VP_PER_PAGE		(0x10000 / 64) // Use sizeof ?
>   #define IND_VP_TABLE_SIZE	((MAX_VP_COUNT / VP_PER_PAGE) * 8)

Reviewed-by: Gustavo Romero <gromero at linux.ibm.com>


Best regards,
Gustavo