[Skiboot] [PATCH] github: update pull request template
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Thu Jun 4 15:51:39 AEST 2020
On 6/4/20 9:23 AM, Oliver O'Halloran wrote:
> The current wording is a bit curt. Flesh it out a bit and put in some
> useful detail.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
> I guess the real question we should be asking is: Why don't we take
> github pull requests? The best answer I can offer is that it seems to
> be impossible to get the DCO (the signed-off-by, etc) correct when using
> PRs since github doesn't let you screw with the patches proper when
> merging a PR. As far as I can tell anyway, I could be wrong.
Looks good to me.
Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
-Vasant
> ---
> .github/pull_request_template.md | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
> index bc7d9614fb5a..ce97aa6b0676 100644
> --- a/.github/pull_request_template.md
> +++ b/.github/pull_request_template.md
> @@ -1,3 +1,18 @@
> -Please do not submit a Pull Request via github. Our project makes use of
> -mailing lists for patch submission and review. For more details please
> -see https://open-power.github.io/skiboot/
> +Hi there,
> +
> +The skiboot project (generally) doesn't take contributions via github pull
> +requests. Contributions should sent to the skiboot mailing list using the
> +git-format-patch and git-send-email tools. If you're unfamiliar with these
> +tools, there's a guide here:
> +
> +https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/
> +
> +The list address is:
> +
> + skiboot at lists.ozlabs.org
> +
> +Posting to the list does not require subscribing to the list. Posts from a
> +non-subscribers are moderated to cut down on spam, but anyone posting
> +genuine contributions will be whitelisted.
> +
> +See https://open-power.github.io/skiboot/ for more details.
>
More information about the Skiboot
mailing list