[Skiboot] [PATCH] github: update pull request template
ajd at linux.ibm.com
Thu Jun 4 15:11:15 AEST 2020
On 4/6/20 1:53 pm, Oliver O'Halloran wrote:
> The current wording is a bit curt. Flesh it out a bit and put in some
> useful detail.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
New message looks good.
Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>
> I guess the real question we should be asking is: Why don't we take
> github pull requests? The best answer I can offer is that it seems to
> be impossible to get the DCO (the signed-off-by, etc) correct when using
> PRs since github doesn't let you screw with the patches proper when
> merging a PR. As far as I can tell anyway, I could be wrong.
The DCO issue is addressable by a CI bot that tells you off for screwing
that up, and then abandoning the idea that the maintainer who commits it
has to add their own SOB. Though there are other cases where maintainers
want to fix up commit messages or minor fixes during merge which aren't
as practical with GitHub.
The bigger issue to me is that I think it's best if the project has one
path for submitting patches. It may be better to be all-or-nothing and
switch to GitHub completely if it suits our needs, I'm less keen on
having 70% of patches go through the mailing list and 30% go through GitHub.
Andrew Donnellan OzLabs, ADL Canberra
ajd at linux.ibm.com IBM Australia Limited
More information about the Skiboot