[Skiboot] [PATCH 2/5] opal/errorlog: Add support to include callout section in error log.

Oliver O'Halloran oohall at gmail.com
Wed Jul 29 21:57:12 AEST 2020


On Wed, Jul 29, 2020 at 9:41 PM Mahesh J Salgaonkar
<mahesh at linux.ibm.com> wrote:
>
> On 2020-07-29 17:12:14 Wed, Oliver O'Halloran wrote:
> > Are any of these structures actually defined by opal? they seem like
> > FSP junk that we just happen to be using...
>
> All the srtuctures defined in this file (pel.h) is as per the PEL
> (Platform Error Log) format and we use it as is for generating PEL error
> logs for FSP/BMC.

Right, don't use opal_* prefixes for definitions unless they're
actually part of an external facing API that OPAL defines. I realise
there's already some code in here that breaks that rule, but I'd
prefer that was fixed rather than continuing the trend.


More information about the Skiboot mailing list