[Skiboot] [PATCH] hdata: Ensure the prd-label hbrt-code-image is prefixed

Oliver O'Halloran oohall at gmail.com
Mon Jul 20 15:48:55 AEST 2020


On Mon, Jul 20, 2020 at 3:46 PM Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
>
> On 7/17/20 9:39 AM, Oliver O'Halloran wrote:
> > Older versions of opal-prd (i.e. most of them shipped by distros)
> > expect the HBRT image to have the PRD label of "ibm,hbrt-code-image".
> > Commit c3bfa3209559 ("hdata: Fix reserved node label search") made
> > opal-prd check for both strings, but since opal-prd itself is the only
> > component interested in locating the hbrt-code-image we might as well
> > just add the prefix in firmware.
> >
> > Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> > Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
>
> Patch looks good to me. May be we should make below change as well.. so that
> `opal-prd`
> search for `ibm,hbrt-code-image` first.

Can't hurt. Send a patch :)


More information about the Skiboot mailing list