[Skiboot] [PATCH] dt: Set new property length in dt_resize_property()

Oliver O'Halloran oohall at gmail.com
Fri Jul 3 15:43:53 AEST 2020


On Fri, Jun 19, 2020 at 12:58 PM Thiago Jung Bauermann
<bauerman at linux.ibm.com> wrote:
>
> All callers of dt_resize_property() need to set the new property length
> after calling it. append_chip_id() wasn't doing it, which caused this
> assert when booting my machine:
>
> *snip*
>
> Avoid further appearances of the unidentified animal of doom by making
> dt_resize_property() do the length updating itself, freeing its callers
> from that need.
>
> Suggested-by: Oliver O'Halloran <oohall at gmail.com>
> Signed-off-by: Thiago Jung Bauermann <bauerman at linux.ibm.com>

Thanks, I'm still surprised we haven't hit this bug until now. Merged
as 5021a037a790.


More information about the Skiboot mailing list