[Skiboot] [PATCH 1/5] hw/phb4: Make error interrupt handler compile

Oliver O'Halloran oohall at gmail.com
Tue Jan 21 18:28:34 AEDT 2020


When phb4.c was copied from phb3.c the error interrupts were disabled by
default and apparently never re-enabled. Remove the #if 0 block and call
phb4_set_err_pending() rather than the phb3 version.

Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
 hw/phb4.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index ed7f4e5c4756..0b7bf778a50e 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -5585,7 +5585,6 @@ static void phb4_err_interrupt(struct irq_source *is, uint32_t isn)
 
 	PHBDBG(p, "Got interrupt 0x%08x\n", isn);
 
-#if 0
 	/* Update pending event */
 	opal_update_pending_evt(OPAL_EVENT_PCI_ERROR,
 				OPAL_EVENT_PCI_ERROR);
@@ -5598,8 +5597,7 @@ static void phb4_err_interrupt(struct irq_source *is, uint32_t isn)
 	 * Mark the PHB has pending error so that the OS
 	 * can handle it at late point.
 	 */
-	phb3_set_err_pending(p, true);
-#endif
+	phb4_set_err_pending(p, true);
 }
 
 static uint64_t phb4_lsi_attributes(struct irq_source *is __unused,
-- 
2.21.1



More information about the Skiboot mailing list