[Skiboot] [PATCH] firenze-pci: Fix infinite loop in firenze_pci_add_loc_code()

Oliver O'Halloran oohall at gmail.com
Thu Feb 27 23:25:53 AEDT 2020


On Thu, Feb 27, 2020 at 10:46 PM Klaus Heinrich Kiwi
<klaus at linux.vnet.ibm.com> wrote:
>
>
>
> On 2/26/2020 2:29 AM, Oliver O'Halloran wrote:
>
> >        */
> > -     for (p = np->parent; p; p = np->parent) {
> > +     for (p = np->parent; p; p = p->parent) {
> >               blcode = dt_prop_get_def(p, "ibm,slot-location-code", NULL);
>
> Good catch!

Less of a catch and more blundering into it after It bricked my Tuleta :(

> I should have seen it the first time..
>
>   -Klaus

I should probably not tell people to use bad code, oh well.


More information about the Skiboot mailing list