[Skiboot] [PATCH] platform: Log error to BMC even if diag data is missing

[Vasant Hegde]

On 2/11/20 5:14 AM, Oliver O'Halloran wrote:
> On Tue, Feb 11, 2020 at 3:44 AM Vasant Hegde
> <hegdevasant at linux.vnet.ibm.com> wrote:
>>
>> Also fix "DESC" to ASCII conversion.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---
>>   core/platform.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/core/platform.c b/core/platform.c
>> index 2544f0ccf..97bc7cb6f 100644
>> --- a/core/platform.c
>> +++ b/core/platform.c
>> @@ -94,10 +94,10 @@ static int64_t opal_cec_reboot2(uint32_t reboot_type, char *diag)
>>                            "OPAL: Reboot requested due to Platform error.");
>>                          if (diag) {
>>                                  /* Add user section "DESC" */
>> -                               log_add_section(buf, 0x44455350);
>> +                               log_add_section(buf, 0x44455343);
> 
> Make it a #define.


Agree. I will send separate patch for this.


>  Also is this going to need to be endian swapped or
> does log_add_section() handle that?

Yes. Endianess is taken care.

-Vasant