[Skiboot] [PATCH] ibm-fsp/lxvpd: check for upstream port on slot labeling

Oliver O'Halloran oohall at gmail.com
Mon Feb 17 14:56:14 AEDT 2020


On Sun, Feb 9, 2020 at 12:49 PM Klaus Heinrich Kiwi
<klaus at linux.vnet.ibm.com> wrote:
>
> Certain FSP configurations include PCIe switches that can have LXVPD
> slot map entries using the same switch-id and dev-id, even if they are
> referring to different upstream and downstream ports of the same link.
>
> The slot matching function (lxvpd_get_slot()) will match the first
> occurence, that can be the upstream port with, and ignore the downstream
> port.
>
> The main symptom for the above is an incorrect label for those slots,
> but I believe other slot attributes could be incorrect as well (as we
> are associating a slot with an upstream port).
>
> This patch picks-up an existing "upstream port" attribute from the 1005
> version of the LXVPD slot map to prevent matching upstream ports on
> the slot matching function.
>
> Signed-off-by: Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>

Merged as 99ce1bef50fc1f7a361e897e261a6eb8f6b36d97 with some fixups
for 80cols compliance.


More information about the Skiboot mailing list