[Skiboot] [Skiboot-stable] [PATCH] capp: Add lid definition for P9 DD2.3

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Feb 14 03:15:26 AEDT 2020


On 2/13/20 1:52 AM, Frederic Barrat wrote:
> Add the definition of the CAPP microcode for DD2.3 to the lid map.
> 
> Cc: skiboot-stable at lists.ozlabs.org # v6.5+
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> ---
> Oliver, Vasant: this is a bug fix for FW941/ZZ-ESS, which I think
> means it should also go to the 6.5 branch
> 
>   hw/fsp/fsp.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
> index 7592ee07..196fa34d 100644
> --- a/hw/fsp/fsp.c
> +++ b/hw/fsp/fsp.c
> @@ -2362,6 +2362,7 @@ int fsp_fetch_data_queue(uint8_t flags, uint16_t id, uint32_t sub_id,
>   #define CAPP_IDX_NIMBUS_DD20 0x200d1
>   #define CAPP_IDX_NIMBUS_DD21 0x201d1
>   #define CAPP_IDX_NIMBUS_DD22 0x202d1
> +#define CAPP_IDX_NIMBUS_DD23 0x203d1
> 
>   #define IMA_CATALOG_NIMBUS	0x4e0200
> 
> @@ -2382,6 +2383,7 @@ static struct {
>   	{ RESOURCE_ID_CAPP,	CAPP_IDX_NIMBUS_DD20,	0x80a02007 },
>   	{ RESOURCE_ID_CAPP,	CAPP_IDX_NIMBUS_DD21,	0x80a02007 },
>   	{ RESOURCE_ID_CAPP,	CAPP_IDX_NIMBUS_DD22,	0x80a02007 },
> +	{ RESOURCE_ID_CAPP,	CAPP_IDX_NIMBUS_DD23,	0x80a02007 },

Patch looks ok to me.  Fixes current issue.

Tested-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


IMO If LID number is fixed across DD versions then we should workout better way to
find LID number and load it automatically (of course may not be worth to make 
change now for ZZ).

-Vasant



More information about the Skiboot mailing list