[Skiboot] [PATCH] opal-gard: Add support for new PVR POWER9P.

Dan Horák dan at danny.cz
Mon Feb 10 19:20:34 AEDT 2020


On Fri, 07 Feb 2020 11:41:48 +0530
Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com> wrote:

> Enable a new PVR for gard tool to work on another p9 variant. Makes
> op-test as well happy.
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  external/gard/gard.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/external/gard/gard.c b/external/gard/gard.c
> index 5e58fede9..8877f1c84 100644
> --- a/external/gard/gard.c
> +++ b/external/gard/gard.c
> @@ -153,6 +153,7 @@ static void guess_chip_gen(void)
>  		return;
>  
>  	case 0x004e: /* nimbus */
> +	case 0x004f: /* Axone */

a nitpick - existing codenames are written all with a lower case first
letter, so Axone should be consistent. I would probably make all
starting with upper case (same as in include/processor.h).


		Dan


More information about the Skiboot mailing list