[Skiboot] [PATCH v3 4/4] API to verify the STOP API and image compatibility

Pratik Sampat psampat at linux.ibm.com
Mon Feb 10 16:43:20 AEDT 2020

On 10/02/20 7:08 am, Oliver O'Halloran wrote:
> On Fri, Feb 7, 2020 at 3:21 PM Pratik Rajesh Sampat
> <psampat at linux.ibm.com> wrote:
>> From: Prem Shanker Jha <premjha2 at in.ibm.com>
>> Commit defines a new API primarily intended for OPAL to determine
>> cpu register save API's compatibility with HOMER layout and
>> self save restore. It can help OPAL determine if version of
>> API integrated with OPAL is different from hostboot.
>> This is used in the context of identifying support for self save in the
>> firmware. In the case the version of the firmware is older then we
>> simply cut support for the feature in the device tree rather than
>> catching the failure when the call is made.
>> Change-Id: Ic0de45a336cfb8b6b6096a10ac1cd3ffbaa44fc0
>> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/77612
>> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot at us.ibm.com>
>> Tested-by: Jenkins Server <pfd-jenkins+hostboot at us.ibm.com>
>> Tested-by: Hostboot CI <hostboot-ci+hostboot at us.ibm.com>
>> Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr at in.ibm.com>
>> Reviewed-by: Gregory S Still <stillgs at us.ibm.com>
>> Reviewed-by: Jennifer A Stofer <stofer at us.ibm.com>
>> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/77614
>> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot at us.ibm.com>
>> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot at us.ibm.com>
>> Reviewed-by: Daniel M Crowell <dcrowell at us.ibm.com>
>> Signed-off-by: Pratik Rajesh Sampat <psampat at linux.ibm.com>
>> Co-authored-by: Prem Shanker Jha <premjha2 at in.ibm.com>
>> Co-authored-by: Pratik Rajesh Sampat <psampat at linux.ibm.com>
> There is a bisect hazard between patch 3 (where self-save is added)
> and patch 4 (where we check if it's supported). IMO, best way to
> resolve this would be:
> 1. Take the slw.c changes out of this patch and move them into the current 3/4.
> 2. Re-order 3/4 and 4/4 so we add support for checking for support
> before we add code to use it.

Alright, that's a cleaner way to do things. I'll reorder them accordingly.



More information about the Skiboot mailing list