[Skiboot] [PATCH v4] hw/npu2-opencapi: Support multiple LPC devices
oohall at gmail.com
Mon Feb 3 12:47:57 AEDT 2020
On Tue, Jan 28, 2020 at 6:21 PM Andrew Donnellan <ajd at linux.ibm.com> wrote:
> Currently, we only have a single range for LPC memory per chip, and we only
> allow a single device to use that range.
> With upcoming Hostboot/SBE changes, we'll use the chip address extension
> mask to give us multiple ranges by using the masked bits of the group ID.
> Each device can now allocate a whole 4TB non-mirrored region. We still
> don't do >4TB ranges.
> If the extension mask is not set correctly, we'll fall back to only
> permitting one device and printing an error suggesting a firmware upgrade.
> Signed-off-by: Andrew Donnellan <ajd at linux.ibm.com>
> I've been able to test this under limited configurations, so far so good.
> - fix excessively large range size which I'd left in there for some reason
> - remove npu->lpc_mem_allocated, which we no longer use (Fred)
> - formatting + comment on magic mask value (Oliver)
Thanks, merged as bc72973d1321546a43f03367b5e73d8ff83a83bd
More information about the Skiboot