[Skiboot] [PATCH] SBE: Account cancelled timer request

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Dec 18 23:10:38 AEDT 2020


Currently we are not accounting cancelled timer request. So in some
corner cases we may schedule new timer request with
new-timer-value > inflight-timer-value.

Lets explicit check new_target value with inflight timer value.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/sbe-p9.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/sbe-p9.c b/hw/sbe-p9.c
index f292d4df8..38e986757 100644
--- a/hw/sbe-p9.c
+++ b/hw/sbe-p9.c
@@ -814,6 +814,9 @@ static void p9_sbe_timer_schedule(void)
 	u64 tb_cnt, now = mftb();
 
 	if (sbe_timer_in_progress) {
+		if (sbe_timer_target >= sbe_last_gen_stamp)
+			return;
+
 		if (now >= sbe_last_gen_stamp)
 			return;
 
-- 
2.26.2



More information about the Skiboot mailing list