[Skiboot] [PATCH] xive/p9: Remove assert from xive_eq_for_target()

Cédric Le Goater clg at kaod.org
Wed Dec 16 19:33:52 AEDT 2020

On 12/16/20 9:03 AM, Vasant Hegde wrote:
> On 11/27/20 1:02 PM, Cédric Le Goater wrote:
>> XIVE VPs are structures describing the vCPUs of guests. When starting
>> a guest, these are allocated and enabled and some checks are done on
>> the location of the associated ENDs, which describe the event
>> queues. If the block of the VP and the block of the ENDs do not match,
>> the XIVE driver asserts.
>> Unfortunately, there is no way to check that a VP identifier is part
>> of a VP block that was previously allocated and it is relatively easy
>> to crash the host with a bogus VP id. That can be done with a QEMU
>> hack on a machine using vsmt.
>> Simply remove the assert, the OS should gracefully handle the error.
> Thanks! Merged to master as of f07ea956.
> Cedric,
> I see that you have marked this to stable tree. Do we need this in 
> all supported stable branches or only in latest stable i.e. v6.7.x?

Since KVM XIVE is supported, so that's v6.3+



More information about the Skiboot mailing list