[Skiboot] [PATCH 2/2] platform/mowgli: Limit PHB0/(pec0) to gen3 speed

[Frederic Barrat]

On 09/12/2020 09:40, Lulu Su wrote:
> From: LuluTHSu <Lulu_Su at wistron.com>
> 
> Use the method provided by Frederic:
> Add the "ibm, maximum link speed" attribute to the PHB device tree at index 0.
> The phb4.c code will looks for it and set up the link correctly.
> 
> Signed-off-by: LuluTHSu <Lulu_Su at wistron.com>
> ---


Looks good to me :-)
Reviewed-by: Frederic Barrat <fbarrat at linux.ibm.com>



>   platforms/astbmc/mowgli.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/platforms/astbmc/mowgli.c b/platforms/astbmc/mowgli.c
> index 213d734..df83319 100644
> --- a/platforms/astbmc/mowgli.c
> +++ b/platforms/astbmc/mowgli.c
> @@ -49,6 +49,21 @@ static void vpd_dt_fixup(void)
>   	}
>   }
>   
> +static void phb0_fixup(void)
> +{
> +	struct dt_node *stk;
> +	u32 phb_index;
> +
> +	/* Limit PHB0/(pec0) to gen3 speed */
> +	dt_for_each_compatible(dt_root, stk, "ibm,power9-phb-stack") {
> +		phb_index = dt_prop_get_u32_def(stk, "ibm,phb-index", -1);
> +		if (phb_index == 0) {
> +			dt_check_del_prop(stk, "ibm,max-link-speed");
> +			dt_add_property_cells(stk, "ibm,max-link-speed", 3);
> +		}
> +	}
> +}
> +
>   static bool mowgli_probe(void)
>   {
>   	if (!dt_node_is_compatible(dt_root, "ibm,mowgli"))
> @@ -63,6 +78,7 @@ static bool mowgli_probe(void)
>   	vpd_dt_fixup();
>   
>   	slot_table_init(mowgli_phb_table);
> +	phb0_fixup();
>   
>   	return true;
>   }
>