[Skiboot] [PATCH v2 06/17] xive/p9: remove code not using block group mode

Oliver O'Halloran oohall at gmail.com
Tue Sep 24 15:40:37 AEST 2019


On Thu, 2019-09-12 at 19:22 +0200, Cédric Le Goater wrote:
> block group mode is now required, it can not be disabled.
> 
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>  hw/xive.c | 209 +-----------------------------------------------------
>  1 file changed, 1 insertion(+), 208 deletions(-)
> 
> diff --git a/hw/xive.c b/hw/xive.c
> index b8be9f42afe0..002f893d5d19 100644
> --- a/hw/xive.c
> +++ b/hw/xive.c
> @@ -19,9 +19,6 @@
> -	/* WARNING: Some workarounds related to cache scrubs require us to
> -	 * have at least one firmware owned (permanent) indirect entry for
> -	 * each XIVE instance. This currently only happens in block group
> -	 * mode
> -	 */
> -#warning Block group mode should not be disabled

Urgh, we should have done this ages ago.



More information about the Skiboot mailing list