[Skiboot] [PATCH 12/16] npu2-opencapi: Detect PHY reset errors

Frederic Barrat fbarrat at linux.ibm.com
Wed Sep 18 01:18:22 AEST 2019



Le 17/09/2019 à 12:00, christophe lombard a écrit :
> On 09/09/2019 14:31, Frederic Barrat wrote:
>> PHY reset can fail! Though past problems are now fixed, let's handle
>> any future failure.
>>
>> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
>> ---
>>   hw/npu2-hw-procedures.c | 13 ++++++++++---
>>   hw/npu2-opencapi.c      |  5 ++++-
>>   include/npu2.h          |  2 +-
>>   3 files changed, 15 insertions(+), 5 deletions(-)
>>
> 
> May be you could add an error message when we face to this specific 
> issue ...


Good point. We only log something if a procedure times out, but not in 
case of straight errors. I'll add it.

   Fred


> 
> Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> 



More information about the Skiboot mailing list