[Skiboot] [PATCH v2 16/17] xive/p9: use predefined bitmasks to manipulate EQ addresses

Cédric Le Goater clg at kaod.org
Fri Sep 13 03:22:17 AEST 2019


Signed-off-by: Cédric Le Goater <clg at kaod.org>
---
 hw/xive.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/xive.c b/hw/xive.c
index b43357296896..b0e3e0c77276 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -3750,7 +3750,7 @@ static int64_t opal_xive_get_queue_info(uint64_t vp, uint32_t prio,
 	if (out_qpage) {
 		if (eq->w0 & EQ_W0_ENQUEUE)
 			*out_qpage =
-				(((uint64_t)(eq->w2 & 0x0fffffff)) << 32) | eq->w3;
+				(((uint64_t)(eq->w2 & EQ_W2_OP_DESC_HI)) << 32) | eq->w3;
 		else
 			*out_qpage = 0;
 	}
@@ -3835,8 +3835,8 @@ static int64_t opal_xive_set_queue_info(uint64_t vp, uint32_t prio,
 		case 16:
 		case 21:
 		case 24:
-			eq.w3 = ((uint64_t)qpage) & 0xffffffff;
-			eq.w2 = (((uint64_t)qpage)) >> 32 & 0x0fffffff;
+			eq.w3 = ((uint64_t)qpage) & EQ_W3_OP_DESC_LO;
+			eq.w2 = (((uint64_t)qpage) >> 32) & EQ_W2_OP_DESC_HI;
 			eq.w0 |= EQ_W0_ENQUEUE;
 			eq.w0 = SETFIELD(EQ_W0_QSIZE, eq.w0, qsize - 12);
 			break;
-- 
2.21.0



More information about the Skiboot mailing list