[Skiboot] [PATCH v4 04/11] doc: add opal secure variable documentation

[Michael Ellerman]

Eric Richter <erichte at linux.ibm.com> writes:
> On 10/29/19 9:06 AM, Oliver O'Halloran wrote:
>> On Tue, 2019-10-29 at 14:47 +1100, Michael Ellerman wrote:
>>> Eric Richter <erichte at linux.ibm.com> writes:
>>>
>>>> +
>>>> +    status:             set to "fail" if the secure variables could not
>>>
>>> It's not clear to me that using status is necessarily the best idea,
>>> given that you also define several other status like properties, and
>>> using the standard status property gives you no ability to express *why*
>>> the status is failed.
>>>
>>> But if you're going to use status then the standard values are
>>> "disabled" and "okay". Also it's an optional property, and an absent
>>> status is equivalent to "okay".
>> 
>> The DT 0.2 spec also allows for "fail" and "fail-sss" where sss is a
>> device-specific reason code.
>
> This is what I intended, although I just noticed from a quick grep that
> apparently nowhere else in skiboot this is used. Should I keep the "fail"
> status, or change it to "disabled" for consistency?

No it's fine to use "fail". I didn't realise that was a specified value
as I've only ever seen "disabled" in the wild.

cheers