[Skiboot] [PATCH 1/4] platforms/swift: Remove spurious error message

Reza Arbab arbab at linux.ibm.com
Wed Oct 23 08:22:21 AEDT 2019

npu3_chip_possible_gpus() works by dividing the number of NVLink-mode
bricks by the number of bricks connecting a single GPU. In a system with
no GPUs, the latter value is unknown, so the function returns zero and
we trip a somewhat misleading error message.

The code afterward is safe to execute in any case, so there's no need to
return either. Remove the check entirely.

Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
 platforms/astbmc/swift.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/platforms/astbmc/swift.c b/platforms/astbmc/swift.c
index e9732236fbd9..d1fb8a8c2d4d 100644
--- a/platforms/astbmc/swift.c
+++ b/platforms/astbmc/swift.c
@@ -63,11 +63,6 @@ static void swift_finalise_dt(bool is_reboot)
 	if (is_reboot)
-	if (npu3_chip_possible_gpus() != 2) {
-		prlog(PR_ERR, "NPU: Unknown link topology detected\n");
-		return;
-	}
 	/* Collect the first link we find for each GPU */
 	npu3_for_each_nvlink_npu(npu) {
 		npu3_for_each_nvlink_dev(dev, npu) {

More information about the Skiboot mailing list