[Skiboot] [PATCH] prd: Improve debug logs

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Oct 22 22:26:43 AEDT 2019


.. helps in debugging.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/prd.c                         | 3 ++-
 platforms/ibm-fsp/hostservices.c | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/prd.c b/hw/prd.c
index db25985b8..d9198f0eb 100644
--- a/hw/prd.c
+++ b/hw/prd.c
@@ -370,7 +370,8 @@ int prd_hbrt_fsp_msg_notify(void *data, u32 dsize)
 	enum opal_msg_type msg_type = OPAL_MSG_PRD2;
 
 	if (!prd_enabled || !prd_active) {
-		prlog(PR_NOTICE, "PRD: PRD daemon is not ready\n");
+		prlog(PR_NOTICE, "PRD: %s: PRD daemon is not ready\n",
+		      __func__);
 		return rc;
 	}
 
diff --git a/platforms/ibm-fsp/hostservices.c b/platforms/ibm-fsp/hostservices.c
index 3bdad4a5e..1c199af11 100644
--- a/platforms/ibm-fsp/hostservices.c
+++ b/platforms/ibm-fsp/hostservices.c
@@ -882,8 +882,10 @@ static bool hservice_hbrt_msg_notify(uint32_t cmd_sub_mod, struct fsp_msg *msg)
 		return true;
 	}
 
-	if (prd_hbrt_fsp_msg_notify(buf, len))
+	if (prd_hbrt_fsp_msg_notify(buf, len)) {
 		hservice_hbrt_msg_response(FSP_STATUS_GENERIC_FAILURE);
+		prlog(PR_NOTICE, "Unable to send FSP - HBRT message\n");
+	}
 
 	return true;
 }
-- 
2.21.0



More information about the Skiboot mailing list