[Skiboot] [PATCH 08/12] ast-io: Fix Ready/Busy indication

[Andrew Jeffery]

On Mon, 21 Oct 2019, at 17:54, Oliver O'Halloran wrote:
> On Fri, Oct 18, 2019 at 8:57 AM Deb McLemore <debmc at linux.ibm.com> wrote:
> >
> > Properly report if the SuperIO is ready or busy.
> >
> > Signed-off-by: Deb McLemore <debmc at linux.ibm.com>
> > ---
> >  hw/ast-bmc/ast-io.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ast-bmc/ast-io.c b/hw/ast-bmc/ast-io.c
> > index 171942a..22fb59f 100644
> > --- a/hw/ast-bmc/ast-io.c
> > +++ b/hw/ast-bmc/ast-io.c
> > @@ -361,7 +361,13 @@ bool ast_sio_init(void)
> >
> >  bool ast_io_is_rw(void)
> >  {
> 
> With the prlog removed:
> 
> > -       return !(ast_ahb_readl(LPC_HICRB) & LPC_HICRB_ILPC_DISABLE);
> > +       int rc;
> > +       rc = ast_ahb_readl(LPC_HICRB);
> > +       return (rc & LPC_HICRB_ILPC_DISABLE);
> 
> So, you're flipping the polarity of the test.
> 
> Now the only real documentation for the ILPC_DISABLE bit I could find
> was Stewart's blog on pantsdown[0] 

Yep, the description in the ASPEED datasheets isn't very helpful.