[Skiboot] [PATCH] chip: enable HOMER/OCC common area region in Qemu emulated PowerNV host

[Cédric Le Goater]

On 14/10/2019 11:48, Balamuruhan S wrote:
> Recent work on Qemu adds support to emulate homer memory region and occ
> common area region with respective device models, so remove `QUIRK_NO_PBA`
> to enable HOMER/OCC common area region code for Qemu emulated PowerNV host.
> 
> Signed-off-by: Balamuruhan S <bala24 at linux.ibm.com>
> ---
>  core/chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/core/chip.c b/core/chip.c
> index 4a4a9a27..d4257df9 100644
> --- a/core/chip.c
> +++ b/core/chip.c
> @@ -133,7 +133,7 @@ void init_chips(void)
>  	if (dt_node_is_compatible(dt_root, "qemu,powernv") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv9")) {
> -		proc_chip_quirks |= QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
> +		proc_chip_quirks |= QUIRK_NO_CHIPTOD
>  			| QUIRK_NO_DIRECT_CTL | QUIRK_NO_RNG;
>  		prlog(PR_NOTICE, "CHIP: Detected Qemu simulator\n");
>  	}
> 
I have been keeping a patch adding QUIRK_QEMU in my tree. see below. 
In case you need to resend, could you please fold the changes in your 
patch ? If not, I will just rebase.

Thanks, 

C. 

Signed-off-by: Cédric Le Goater <clg at kaod.org>
---
 core/chip.c    |    5 +++--
 include/chip.h |    1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

Index: skiboot-p10.git/core/chip.c
===================================================================
--- skiboot-p10.git.orig/core/chip.c
+++ skiboot-p10.git/core/chip.c
@@ -141,9 +141,10 @@ void init_chips(void)
 	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
 	    dt_node_is_compatible(dt_root, "qemu,powernv9") ||
 	    dt_node_is_compatible(dt_root, "qemu,powernv10")) {
-		proc_chip_quirks |= QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
+		proc_chip_quirks |= QUIRK_QEMU
+			| QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
 			| QUIRK_NO_DIRECT_CTL | QUIRK_NO_RNG;
-		prlog(PR_NOTICE, "CHIP: Detected Qemu simulator\n");
+		prlog(PR_NOTICE, "CHIP: Detected QEMU simulator\n");
 	}
 
 	/* We walk the chips based on xscom nodes in the tree */
Index: skiboot-p10.git/include/chip.h
===================================================================
--- skiboot-p10.git.orig/include/chip.h
+++ skiboot-p10.git/include/chip.h
@@ -150,6 +150,7 @@ enum proc_chip_quirks {
 	QUIRK_SLOW_SIM		= 0x00000040,
 	QUIRK_NO_DIRECT_CTL	= 0x00000080,
 	QUIRK_NO_RNG		= 0x00000100,
+	QUIRK_QEMU		= 0x00000200,
 };
 
 extern enum proc_chip_quirks proc_chip_quirks;