[Skiboot] [PATCH v5 03/27] capp: fix endian conversion

Nicholas Piggin npiggin at gmail.com
Tue Oct 15 14:06:53 AEDT 2019


Acked-by: Stewart Smith <stewart at flamingspork.com>
Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 hw/capp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/capp.c b/hw/capp.c
index 709e6db14..269deb637 100644
--- a/hw/capp.c
+++ b/hw/capp.c
@@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, uint32_t opal_id,
 
 	/* 'CAPPULID' in ASCII */
 	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
-	    (be64_to_cpu(ucode->version != 1))) {
+	    (be64_to_cpu(ucode->version) != 1)) {
 		PHBERR(opal_id, chip_id, index,
 		       "CAPP: ucode header invalid\n");
 		return OPAL_HARDWARE;
-- 
2.23.0



More information about the Skiboot mailing list